Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: multiple OCaml versions #1040

Merged
merged 2 commits into from
Jan 27, 2024
Merged

CI: multiple OCaml versions #1040

merged 2 commits into from
Jan 27, 2024

Conversation

liyishuai
Copy link
Contributor

Prevent future versions of #1022

JasonGross
JasonGross requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@JasonGross JasonGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update

concurrency:
      group: ${{ github.workflow }}-${{ matrix.target }}-Ubuntu-${{ github.event_name }}-${{ github.head_ref || github.run_id }}

to include ${{ matrix.ocaml_version }} to avoid one ocaml version cancelling the others

@mattam82
Copy link
Member

I'd rather have just 4.09 than all the intermediate version, this is somewhat costly otherwise.

@mattam82 mattam82 merged commit 44c204b into MetaCoq:coq-8.17 Jan 27, 2024
5 checks passed
@liyishuai liyishuai deleted the patch-1 branch January 28, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGross JasonGross JasonGross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyishuai @mattam82 @JasonGross